-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conflicting Sync error. #857
Conversation
🦋 Changeset detectedLatest commit: 4a681bb The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
TBDocs Report 🛑 Errors: 0 @web5/api
@web5/crypto
@web5/crypto-aws-kms
@web5/dids
@web5/credentials
TBDocs Report Updated at 2024-08-29T18:23:14Z |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #857 +/- ##
=======================================
Coverage 93.41% 93.42%
=======================================
Files 118 118
Lines 33096 33134 +38
Branches 2648 2649 +1
=======================================
+ Hits 30918 30956 +38
Misses 2138 2138
Partials 40 40
|
91c63ca
to
d6e6f69
Compare
When I added the one-shot
sync()
method I put in a guard to prevent it from being called while an interval was running. This caused a bug in the interval, so I've modified the code to account for it.Also updated some type docs to get rid of the warning.