-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
connect dwn integration #850
Conversation
🦋 Changeset detectedLatest commit: da94c19 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
TBDocs Report 🛑 Errors: 0 @web5/api
@web5/crypto
@web5/crypto-aws-kms
@web5/dids
@web5/credentials
TBDocs Report Updated at 2024-08-26T16:56:08Z |
packages/api/tests/web5.spec.ts
Outdated
@@ -393,366 +393,7 @@ describe('web5 api', () => { | |||
await appTestHarness.closeStorage(); | |||
}); | |||
|
|||
it('logs an error if there is a failure during cleanup of Identity information, but does not throw', async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
noticed these 3 duplicated tests?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #850 +/- ##
==========================================
- Coverage 93.37% 93.32% -0.06%
==========================================
Files 117 117
Lines 32820 32923 +103
Branches 2605 2613 +8
==========================================
+ Hits 30647 30726 +79
- Misses 2134 2158 +24
Partials 39 39
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Just one small thing, we added that delegateGrants
return from Web5.connect()
as just our own visual testing. But now that delegate sync is in we can just write a record or something.
No description provided.