Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connect dwn integration #850

Merged
merged 16 commits into from
Aug 26, 2024
Merged

connect dwn integration #850

merged 16 commits into from
Aug 26, 2024

Conversation

shamilovtim
Copy link
Contributor

No description provided.

Copy link

changeset-bot bot commented Aug 21, 2024

🦋 Changeset detected

Latest commit: da94c19

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@web5/agent Patch
@web5/api Minor
@web5/user-agent Patch
@web5/proxy-agent Patch
@web5/identity-agent Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@shamilovtim shamilovtim changed the title init connect dwn integration connect dwn integration Aug 21, 2024
Copy link
Contributor

github-actions bot commented Aug 21, 2024

TBDocs Report

🛑 Errors: 0
⚠️ Warnings: 5

@web5/api

  • Project entry file: packages/api/src/index.ts

@web5/crypto

  • Project entry file: packages/crypto/src/index.ts
📄 File: ./packages/crypto/src/utils.ts
⚠️ extractor:typedoc:missing-docs: CryptoUtils (Variable) does not have any documentation.
⚠️ extractor:typedoc:missing-docs: CryptoUtils.__type.randomPin (Property) does not have any documentation.
⚠️ extractor:typedoc:missing-docs: CryptoUtils.__type.randomUuid (Property) does not have any documentation.
⚠️ extractor:typedoc:missing-docs: CryptoUtils.__type.randomBytes (Property) does not have any documentation.
⚠️ extractor:typedoc:missing-docs: CryptoUtils.__type.getJoseSignatureAlgorithmFromPublicKey (Property) does not have any documentation.

@web5/crypto-aws-kms

  • Project entry file: packages/crypto-aws-kms/src/index.ts

@web5/dids

  • Project entry file: packages/dids/src/index.ts

@web5/credentials

  • Project entry file: packages/credentials/src/index.ts

TBDocs Report Updated at 2024-08-26T16:56:08Z da94c19

@shamilovtim shamilovtim marked this pull request as ready for review August 23, 2024 19:35
@@ -393,366 +393,7 @@ describe('web5 api', () => {
await appTestHarness.closeStorage();
});

it('logs an error if there is a failure during cleanup of Identity information, but does not throw', async () => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noticed these 3 duplicated tests?

Copy link

codecov bot commented Aug 23, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 24 lines in your changes missing coverage. Please review.

Project coverage is 93.32%. Comparing base (2f7bbbe) to head (da94c19).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #850      +/-   ##
==========================================
- Coverage   93.37%   93.32%   -0.06%     
==========================================
  Files         117      117              
  Lines       32820    32923     +103     
  Branches     2605     2613       +8     
==========================================
+ Hits        30647    30726      +79     
- Misses       2134     2158      +24     
  Partials       39       39              
Components Coverage Δ
agent 87.10% <84.90%> (-0.10%) ⬇️
api 99.55% <100.00%> (+<0.01%) ⬆️
common 98.68% <ø> (ø)
credentials 94.95% <ø> (ø)
crypto 93.79% <ø> (ø)
dids 97.77% <ø> (ø)
identity-agent 96.42% <ø> (ø)
crypto-aws-kms 100.00% <ø> (ø)
proxy-agent 96.42% <ø> (ø)
user-agent 96.42% <ø> (ø)

Copy link
Member

@LiranCohen LiranCohen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just one small thing, we added that delegateGrants return from Web5.connect() as just our own visual testing. But now that delegate sync is in we can just write a record or something.

packages/api/src/web5.ts Outdated Show resolved Hide resolved
examples/wallet-connect.html Outdated Show resolved Hide resolved
@shamilovtim shamilovtim requested a review from LiranCohen August 26, 2024 16:54
@shamilovtim shamilovtim merged commit fea0535 into main Aug 26, 2024
35 checks passed
@shamilovtim shamilovtim deleted the tshamilov/connect-dwn-integration branch August 26, 2024 17:13
@github-actions github-actions bot mentioned this pull request Aug 26, 2024
This was referenced Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants