-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DWN Registration #769
DWN Registration #769
Conversation
🦋 Changeset detectedLatest commit: cf7b4dc The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
TBDocs Report ✅ No errors or warnings @web5/api
@web5/crypto
@web5/crypto-aws-kms
@web5/dids
@web5/credentials
TBDocs Report Updated at 2024-07-17T23:39:11Z |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might want to fix the low hanging missing docs, else every PR going forward is going to be blocked (for people with no override power).
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #769 +/- ##
=======================================
Coverage 92.78% 92.78%
=======================================
Files 109 109
Lines 29920 29961 +41
Branches 2303 2311 +8
=======================================
+ Hits 27760 27800 +40
Misses 2125 2125
- Partials 35 36 +1
|
Allows for DWN registration by passing in a
registration
object toWeb5.connect()
The registration object takes
onSuccess()
andonFailure()
methods, which are called respectively if registration succeeds or fails for the given DWN Endpoints that require registration.Each are only called once if all succeed or any failures happen.
If none of the endpoints require registration neither are called.