Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DWN Registration #769

Merged
merged 5 commits into from
Jul 17, 2024
Merged

DWN Registration #769

merged 5 commits into from
Jul 17, 2024

Conversation

LiranCohen
Copy link
Member

@LiranCohen LiranCohen commented Jul 17, 2024

Allows for DWN registration by passing in a registration object to Web5.connect()

The registration object takes onSuccess() and onFailure() methods, which are called respectively if registration succeeds or fails for the given DWN Endpoints that require registration.

Each are only called once if all succeed or any failures happen.

If none of the endpoints require registration neither are called.

Copy link

changeset-bot bot commented Jul 17, 2024

🦋 Changeset detected

Latest commit: cf7b4dc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@web5/api Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jul 17, 2024

TBDocs Report

✅ No errors or warnings

@web5/api

  • Project entry file: packages/api/src/index.ts

@web5/crypto

  • Project entry file: packages/crypto/src/index.ts

@web5/crypto-aws-kms

  • Project entry file: packages/crypto-aws-kms/src/index.ts

@web5/dids

  • Project entry file: packages/dids/src/index.ts

@web5/credentials

  • Project entry file: packages/credentials/src/index.ts

TBDocs Report Updated at 2024-07-17T23:39:11Z cf7b4dc

thehenrytsai
thehenrytsai previously approved these changes Jul 17, 2024
Copy link
Contributor

@thehenrytsai thehenrytsai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might want to fix the low hanging missing docs, else every PR going forward is going to be blocked (for people with no override power).

Copy link

codecov bot commented Jul 17, 2024

Codecov Report

Attention: Patch coverage is 97.67442% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.78%. Comparing base (8baa679) to head (cf7b4dc).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #769   +/-   ##
=======================================
  Coverage   92.78%   92.78%           
=======================================
  Files         109      109           
  Lines       29920    29961   +41     
  Branches     2303     2311    +8     
=======================================
+ Hits        27760    27800   +40     
  Misses       2125     2125           
- Partials       35       36    +1     
Components Coverage Δ
agent 85.22% <ø> (ø)
api 98.99% <97.67%> (-0.03%) ⬇️
common 98.68% <ø> (ø)
credentials 94.69% <ø> (ø)
crypto 93.81% <ø> (ø)
dids 97.77% <ø> (ø)
identity-agent 96.70% <ø> (ø)
crypto-aws-kms 100.00% <ø> (ø)
proxy-agent 96.70% <ø> (ø)
user-agent 96.70% <ø> (ø)

@LiranCohen LiranCohen marked this pull request as ready for review July 17, 2024 23:11
@LiranCohen LiranCohen requested a review from diehuxx as a code owner July 17, 2024 23:12
@LiranCohen LiranCohen merged commit d18aa6b into main Jul 17, 2024
35 checks passed
@LiranCohen LiranCohen deleted the lirancohen/api-dwn-registration branch July 17, 2024 23:49
@github-actions github-actions bot mentioned this pull request Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants