Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Docstring point to wrong file/line #408

Closed
haarts opened this issue Jun 7, 2023 · 1 comment · Fixed by #411
Closed

[Bug] Docstring point to wrong file/line #408

haarts opened this issue Jun 7, 2023 · 1 comment · Fixed by #411
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@haarts
Copy link

haarts commented Jun 7, 2023

Describe the bug
This is a really trivial bug. I'm almost ashamed of submitting it.

In this example there's a reference to a file/line that no longer exists/is moved: https://github.com/TBD54566975/ssi-sdk/blob/main/example/did/did.go#L20.
I think it should point here: https://github.com/TBD54566975/ssi-sdk/blob/main/did/key/key.go#L96

To Reproduce
n/a

Expected behavior
Clearly it should point to the right place.

Supporting Material
n/a

Environment (please complete the following information):

The issue is at least present in commit 989cdd2

@haarts haarts added the bug Something isn't working label Jun 7, 2023
@andresuribe87
Copy link
Contributor

Thanks @haarts ! Fix is underway. We also accept PRs :)

@decentralgabe decentralgabe added documentation Improvements or additions to documentation and removed bug Something isn't working labels Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants