-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: simplify Dockerfiles #3565
Conversation
247414f
to
f888ad9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we also need to update the release workflows.
f888ad9
to
c2c3afd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also the Justfile in ./deployments needs to be updated, as it was relying on the .test
dockerfiles.
Already done :) |
Ah yep, will do that now. |
c2c3afd
to
dde7215
Compare
8d488d9
to
a235c1d
Compare
Updated, but I'm not sure it's being exercised in CI (?), so it might need a manual check potentially. |
Mmm well some of the CI jobs are failing, so I guess that answers that question 😂 |
Smoke Test Upgrade Path got broken by a different PR, so don't worry about that one. I can look at fixing TestKubeScaling tomorrow if you want. |
a235c1d
to
47d9a3b
Compare
47d9a3b
to
438c36d
Compare
Ah, kk. I think I have TestKubeScaling working, it was just some stupid stuff in the builds. |
Mmm okay I spoke too soon; everything is working except TestKubeScaling :( |
Consolidates on a single
Dockerfile
for all primary services. Language-specific runners require a separate Dockerfile each in the formDockerfile.runner-<language>
. Build all of these withjust build-docker <name>
, eg.just build-docker runner-jvm
.Also adds a
just list-docker-images
, and updates ci.yml to build via a matrix using this.Warning
In order to simplify the Dockerfiles this changes a bunch of environment variables , which might break due to downstream infra that set the old values.