chore: convert database runtime to a oneof to support more connection methods in the future #3499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
jvmakine
commented
Nov 25, 2024
| @@ -36,6 +36,11 @@ message Config { | |||
| Type type = 4; | |||
| } | |||
|
|
|||
| message DSNDatabaseRuntime { | |||
There was a problem hiding this comment.
This generated code is the crux of this change
jvmakine
added
the
skip-proto-breaking
jvmakine
force-pushed
the
juho/schema-runtime-resources
branch
3 times, most recently
from
e86d274
to
acf9326
Compare
… methods in the future
jvmakine
force-pushed
the
juho/schema-runtime-resources
branch
from
acf9326
to
87055af
Compare
stuartwdouglas
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is to have the different ways to do DB connections in the DatabaseRuntime, and then to use that in DB proxies to establish the connection.