Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure Jackson annotations are taking into account in schema generation #2619

Open
stuartwdouglas opened this issue Sep 5, 2024 · 2 comments
Assignees
Labels
good first issue Good for newcomers jvm

Comments

@stuartwdouglas
Copy link
Collaborator

e.g. if a field is renamed via Jackson annotations this should be picked up in schema extraction

@stuartwdouglas stuartwdouglas added good first issue Good for newcomers jvm labels Sep 5, 2024
@github-actions github-actions bot added the triage Issue needs triaging label Sep 5, 2024
@jvmakine jvmakine removed the triage Issue needs triaging label Sep 5, 2024
@tomdaffurn
Copy link
Contributor

tomdaffurn commented Sep 6, 2024

So with this class, the schema should have a FirstName field, not a first field:

public class Person {
    @JsonProperty("FirstName")
    private String first;
}

@stuartwdouglas
Copy link
Collaborator Author

Yes, that is correct

@tomdaffurn tomdaffurn self-assigned this Oct 15, 2024
@ftl-robot ftl-robot mentioned this issue Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers jvm
Projects
None yet
Development

No branches or pull requests

3 participants