Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TAPi18n._afterUILanguageChange should be called in startup() #15

Open
derwaldgeist opened this issue Aug 22, 2017 · 0 comments
Open

TAPi18n._afterUILanguageChange should be called in startup() #15

derwaldgeist opened this issue Aug 22, 2017 · 0 comments

Comments

@derwaldgeist
Copy link

I just noted in my app that the _afterUILanguageChange() hook was broken. Whereas it worked in this combination: tap:[email protected]' and [email protected], after the switch to tap:[email protected]and[email protected]the hook wasn't executed anymore. My hook was replaced by a generic function that just returnednull. After I put the hook setup in a Meteor.startup()block, however, it worked again. So I think it should be mentioned in the docs that the hook should be set on startup. Or, it should be ensured thattap:i18n` doesn't overwrite it if it already has been set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant