Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use array index in identifiers #19

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

bwhitchurch
Copy link
Contributor

This changes the identifier string for register arrays to use the array index rather than size of the array dimension. It addresses the basic issue raised in #5.

@MarekPikula MarekPikula self-requested a review June 3, 2024 20:51
Copy link
Member

@MarekPikula MarekPikula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you for contribution :)

@coveralls
Copy link

coveralls commented Jun 3, 2024

Pull Request Test Coverage Report for Build 9355208716

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 88.095%

Totals Coverage Status
Change from base Build 8711348166: 0.0%
Covered Lines: 148
Relevant Lines: 168

💛 - Coveralls

@MarekPikula MarekPikula merged commit bee4cd1 into SystemRDL:main Jun 3, 2024
17 checks passed
@bwhitchurch bwhitchurch deleted the register-arrays branch June 4, 2024 16:10
@jeras
Copy link

jeras commented Jun 4, 2024

I just tested it, it works as described.

Array elements in the address table are now properly indexed. It works for multidimensional arrays too.

The repetitive documentation for each array element remains. All instances have the same heading, giving no indication which index are they, they differ only in the absolute address.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants