-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support proteins field that match genes #558
Comments
In PR #559, functions |
I've imported the same |
Thanks for reporting, then I misinterpreted COBRA, I now see that they indeed never add the |
@edkerk I agree with the suggested approach, will fix as new PR. |
Description of the issue:
COBRA has
protein
andproteinNames
fields that match thegenes
field in size (which means that each gene can be associated to one protein). These are read from the SBML file from thefbc_geneProduct.fbc_name
tag that is currently not considered by RAVEN. It would be convenient to support such a protein field as well.proteins
is an identifier field, which means that (if the field exists) it cannot be empty. COBRA solves this by filling it withCOBRAprotein1
etc. if no value was found in the SBML file.proteinNames
has then the same content, but without filling empty entries withCOBRAprotein1
etc. As theproteins
field is currently not used for anything (COBRA nor RAVEN), there is little reason to support this at the moment, while it is mostly redundant in comparison withproteinNames
. Therefore, only theproteinNames
field will be implemented. To ensure cross-compatibility, we will stick to the same field names.I hereby confirm that I have:
The text was updated successfully, but these errors were encountered: