update ismrmrdtools

[KrisThielemans]

we're currently pulling from our own clone

SyneRBI_VM/scripts/UPDATE.sh

Line 298 in b09dc99

clone_or_pull https://github.com/SyneRBI/ismrmrd-python-tools.git

which is very much out of date, including python2 errors.

I cannot remember why we didn't pull from https://github.com/ismrmrd/ismrmrd-python-tools

[KrisThielemans]

@johannesmayer @ckolbPTB @DANAJK maybe you could investigate?

[KrisThielemans]

Pinging @johannesmayer @ckolbPTB @DANAJK

[johannesmayer]

Where do we use these tools?
For coil sensitivity computation?

[KrisThielemans]

I guess so. We're not using them directly in the exercises as far as I'm aware, but if people use their own data and see that it's installed, they could naturally assume that they will work, and they don't.

I'd be ok with just upgrading, but I'd appreciate a quick look if we did something weird on our own clone. Easiest might be to (in your own VM) merge the upstream master, and then see if there are any difference with upstream master

[johannesmayer]

Alright thanks I will get on it

[johannesmayer]

Easiest might be to (in your own VM) merge the upstream master, and then see if there are any difference with upstream master

I hope I interpreted your comment correctly: I went into the repository that is generated from our clone https://github.com/SyneRBI/ismrmrd-python-tools.git and did:

git add remote ismrmrd https://github.com/ismrmrd/ismrmrd-python-tools.git
git fetch --all
git pull origin master
git diff master..ismrmrd/master

and the differences are things all of the kind to ensure integer division e.g. replacing data.size/data.shape[0] by data.size//data.shape[0], casting to integer, and adding one import and parentheses to a print statement.

Our clone contains basically nothing different, at least nothing was revealed from the git commands that I wrote above.

[KrisThielemans]

I guess I'm interested in

git pull ismrmrd master
git diff master..ismrmrd/master

I hope there will be no differences, in which case we can just update our clone.

[johannesmayer]

alright now I get it, that's much smarter...
No difference.

[KrisThielemans]

@paskino, given @johannesmayer 's work, let's just switch to use the normal repo and forget about our clone