Skip to content
This repository has been archived by the owner on Aug 20, 2022. It is now read-only.

rename (or drop?) SIRF_SRC_PATH #116

Open
KrisThielemans opened this issue Mar 3, 2019 · 0 comments
Open

rename (or drop?) SIRF_SRC_PATH #116

KrisThielemans opened this issue Mar 3, 2019 · 0 comments
Assignees
Milestone

Comments

@KrisThielemans
Copy link
Member

we have 2 variables SIRF_PATH (set to /home/sirfuser/devel/buildVM/sources/SIRF/) and SIRF_SRC_PATH (set to /home/sirfuser/devel). The first is pointing to the source, and its name is determined by code in SIRF. The second is a VM variable only. It was introduced to allow us to put things elsewhere than ~/devel.

It's used in 2 places essentially (aside from internal usage in UPDATE.sh):

  • update_VM_to_full_STIR.sh to know where to install STIR-exercises (but it could get this from SIRF_PATH/../../..
  • UPDATE.sh checks the existence of this variable and if does puts everything there. At the end, it writes it in ~/.sirfrc.

I suggest therefore

  • to remove it from update_VM_to_full_STIR.sh ,
  • give UPDATE.sh an option to specify it, which defaults to SIRF_SRC_PATH if it exists or ~/devel otherwise.
  • No longer put it in ~/.sirfrc
@KrisThielemans KrisThielemans added this to the v2.0 milestone Mar 3, 2019
@KrisThielemans KrisThielemans modified the milestones: v2.0, v2.1 May 10, 2019
@KrisThielemans KrisThielemans modified the milestones: v2.1, v2.2 Oct 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants