-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
compilation failure with DISABLE_GADGETRON=ON due to syn_utilities #622
Comments
I see that Keeping in Seems therefore to me that |
I just did it the simplest way (as usual, not being clever enough to work out complicated solutions:-)). And sorry about that cmake kludge intended to stop Travis from going red on some builds. I will think about other ways, but there is something I do not quite understand: since the synergistic stuff is supposed to explicitly deal with STIR and Gadgetron (see |
Step 1:
Step 2:
|
FYI - this also affects DISABLE_STIR and DISABLE_Registration. I couldn't quite tell from the proposed solution if that would get fixed too, I guess so. Ash |
This is unfortunate, as some people will want to disable certain components as they have problems with compilers etc (and if they don't need the component, shouldn't have to bother with it). It's too long ago for me to remember it all, and my writing above isn't quite crystal clear, I don't have a good feeling for how much work step 1 would be. Doesn't sound like a lot, but these things tend to explode. |
The synergistic library/executables/tests have now been adapted for DISABLE_Gadgetron etc. The work-around in common/utilities.* has therefore been removed. a job with DISABLE_Gadgetron has been added to GHA Fixes SyneRBI#622
The synergistic library/executables/tests have now been adapted for DISABLE_Gadgetron etc. The work-around in common/utilities.* has therefore been removed. a job with DISABLE_Gadgetron has been added to GHA Fixes SyneRBI#622
syn_utilities.cxx fails to compile in that case as it doesn't know about include gadgetron_data_containers.h etc
SIRF/src/common/syn_utilities.cpp
Lines 32 to 35 in 6854699
I'm a bit confused about all this.
Synergistic
.Syn/utilities.h
, which defines the classImageDataWrap
butImageWrap
existing all the time (so incommon
I guess), but use preprocessor defines to exclude lines insyn_utilities.cpp
that won't compile if an engine is not available.CMakeListst.txt
seems to imply thatsyn_utilities.ccp
should only be compiled when all engines are present, which seems to be the opposite to what was intendedSIRF/src/common/CMakeLists.txt
Lines 30 to 45 in 6854699
The text was updated successfully, but these errors were encountered: