Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: handle mapped name in nested arrays #185

Merged
merged 3 commits into from
Mar 8, 2018

Conversation

Idered
Copy link
Member

@Idered Idered commented Mar 8, 2018

No description provided.

@Idered Idered self-assigned this Mar 8, 2018
@Idered Idered requested a review from mkucharz March 8, 2018 14:30
@codecov-io
Copy link

codecov-io commented Mar 8, 2018

Codecov Report

Merging #185 into master will increase coverage by 1.65%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #185      +/-   ##
==========================================
+ Coverage   29.06%   30.72%   +1.65%     
==========================================
  Files         102      114      +12     
  Lines        2866     4290    +1424     
==========================================
+ Hits          833     1318     +485     
- Misses       2033     2972     +939

@@ -825,6 +825,43 @@ describe('Data', () => {
.should.become([{author: 'John', views: 100}])
})

it.only('should work with nested array of objects', () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove only.

@Idered Idered merged commit 6f49966 into master Mar 8, 2018
@Idered Idered deleted the feature/nested-arrays-fields-method branch March 8, 2018 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants