Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move fos rest, jms serializer and hateoas on optional requirements #872

Merged
merged 5 commits into from
May 24, 2024

Conversation

loic425
Copy link
Member

@loic425 loic425 commented May 15, 2024

Q A
Bug fix? no
New feature? no
BC breaks? mentioned in upgrade
Deprecations? no
Related tickets
License MIT

It's time to get rid of these packages. Let's start by moving them on optional requirements.

  • move on dev dependencies
  • fix DI
  • FosRestPassTest
  • HateoasPassTest

@loic425 loic425 requested a review from a team as a code owner May 15, 2024 10:29
@loic425 loic425 force-pushed the dev-dependencies/move-hateoas branch 2 times, most recently from 9a4ca49 to 1cfad13 Compare May 15, 2024 12:15
@loic425 loic425 marked this pull request as draft May 15, 2024 12:54
@loic425 loic425 force-pushed the dev-dependencies/move-hateoas branch from 995516f to 20287f8 Compare May 15, 2024 13:31
@loic425 loic425 marked this pull request as ready for review May 15, 2024 13:43
@loic425 loic425 force-pushed the dev-dependencies/move-hateoas branch from 3bfee1b to 06a8cf0 Compare May 15, 2024 13:47
@loic425 loic425 changed the title Move fos rest, jms serializer and hateoas on dev requirements Move fos rest, jms serializer and hateoas on optional requirements May 15, 2024
UPGRADE.md Outdated Show resolved Hide resolved
src/Bundle/DependencyInjection/Compiler/FosRestPass.php Outdated Show resolved Hide resolved
src/Bundle/DependencyInjection/Compiler/HateoasPass.php Outdated Show resolved Hide resolved
@loic425 loic425 force-pushed the dev-dependencies/move-hateoas branch from c253a67 to 0c7d327 Compare May 16, 2024 07:44
@loic425 loic425 force-pushed the dev-dependencies/move-hateoas branch from 0c7d327 to 10e80cf Compare May 23, 2024 07:08
@GSadee GSadee merged commit 1c7cc9c into Sylius:1.12 May 24, 2024
19 checks passed
@GSadee
Copy link
Member

GSadee commented May 24, 2024

Thank you, Loïc! 🎉

@loic425 loic425 deleted the dev-dependencies/move-hateoas branch May 24, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants