Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests with grids #478

Merged
merged 2 commits into from
Oct 18, 2022
Merged

Add tests with grids #478

merged 2 commits into from
Oct 18, 2022

Conversation

loic425
Copy link
Member

@loic425 loic425 commented Aug 24, 2022

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets
License MIT

@loic425 loic425 requested a review from a team as a code owner August 24, 2022 10:10
@loic425 loic425 changed the title Add a test with grids Add tests with grids Aug 24, 2022
@Zales0123 Zales0123 force-pushed the test-with-grids branch 6 times, most recently from a00fd9e to a97e331 Compare October 13, 2022 07:20
@Zales0123 Zales0123 added Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). DX Issues and PRs aimed at improving Developer eXperience. labels Oct 18, 2022
@Zales0123 Zales0123 merged commit 764f8bd into Sylius:1.10 Oct 18, 2022
@Zales0123
Copy link
Member

Thank you, @loic425! 🎉

@loic425 loic425 deleted the test-with-grids branch October 18, 2022 09:03
Zales0123 added a commit that referenced this pull request Oct 18, 2022
@Zales0123
Generate changelog for v1.10.0-BETA.1
5d59430 
- [#341](#341) Dropping usage of Request->get ([@loic425](https://github.com/loic425), [@Zales0123](https://github.com/Zales0123))
- [#450](#450) Adjust when some runtime deprecation notices are triggered and use Symfony's trigger_deprecation() helper ([@mbabker](https://github.com/mbabker))
- [#467](#467) [README] Add development section and update links ([@lchrusciel](https://github.com/lchrusciel))
- [#478](#478) Add tests with grids ([@loic425](https://github.com/loic425))
- [#487](#487) Make CsrfTokenManager public ([@Zales0123](https://github.com/Zales0123))
- [#488](#488) Return 422 status code when the form fails ([@belmeopmenieuwesim](https://github.com/belmeopmenieuwesim), [@Zales0123](https://github.com/Zales0123))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zales0123 Zales0123 Zales0123 approved these changes

Assignees
No one assigned
Labels
DX Issues and PRs aimed at improving Developer eXperience. Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@loic425 @Zales0123