Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropping usage of Request->get #341

Merged
merged 4 commits into from
Oct 18, 2022
Merged

Dropping usage of Request->get #341

merged 4 commits into from
Oct 18, 2022

Conversation

loic425
Copy link
Member

@loic425 loic425 commented Dec 16, 2021

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets
License MIT

@loic425 loic425 requested a review from a team as a code owner December 16, 2021 00:52
@loic425 loic425 changed the title WIP fix CI [WIP] Dropping usage of Request->get Dec 20, 2021
@Zales0123
Copy link
Member

Should be ready for the next iteration when rebase after #342 is merged 🖖

@Zales0123 Zales0123 added the Bug Confirmed bugs or bugfixes. label Dec 20, 2021
@lchrusciel lchrusciel changed the base branch from master to 1.10 April 15, 2022 12:26
@Zales0123 Zales0123 changed the title [WIP] Dropping usage of Request->get Dropping usage of Request->get Oct 18, 2022
@Zales0123 Zales0123 merged commit 54dd5e8 into Sylius:1.10 Oct 18, 2022
@Zales0123
Copy link
Member

Thanks, Loïc! 🎉

@loic425 loic425 deleted the fix/ci branch October 18, 2022 09:04
Zales0123 added a commit that referenced this pull request Oct 18, 2022
- [#341](#341) Dropping usage of Request->get ([@loic425](https://github.com/loic425), [@Zales0123](https://github.com/Zales0123))
- [#450](#450) Adjust when some runtime deprecation notices are triggered and use Symfony's trigger_deprecation() helper ([@mbabker](https://github.com/mbabker))
- [#467](#467) [README] Add development section and update links ([@lchrusciel](https://github.com/lchrusciel))
- [#478](#478) Add tests with grids ([@loic425](https://github.com/loic425))
- [#487](#487) Make CsrfTokenManager public ([@Zales0123](https://github.com/Zales0123))
- [#488](#488) Return 422 status code when the form fails ([@belmeopmenieuwesim](https://github.com/belmeopmenieuwesim), [@Zales0123](https://github.com/Zales0123))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Confirmed bugs or bugfixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants