Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some Symfony Deprecations #338

Merged
merged 7 commits into from
Feb 28, 2022
Merged

Fix some Symfony Deprecations #338

merged 7 commits into from
Feb 28, 2022

Conversation

dannyvw
Copy link
Contributor

@dannyvw dannyvw commented Dec 11, 2021

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? yes
Related tickets partially #335
License MIT

@dannyvw dannyvw requested a review from a team as a code owner December 11, 2021 15:03
@Roshyo
Copy link
Contributor

Roshyo commented Dec 21, 2021

I agree with the double colon syntax change. But the other ones introduce BC break. I think we could do it in separated PRs

@stloyd
Copy link
Contributor

stloyd commented Jan 22, 2022 •
edited
Loading

@Roshyo There is no BC break cause all changed classes are final.

@Roshyo
Copy link
Contributor

Roshyo commented Jan 22, 2022

@stloyd you are right, indeed. lgtm

@Zales0123 Zales0123 added DX Issues and PRs aimed at improving Developer eXperience. Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). labels Feb 28, 2022
@Zales0123 Zales0123 merged commit 7acdfb9 into Sylius:master Feb 28, 2022
@dannyvw dannyvw deleted the deprecations branch February 28, 2022 11:01
Zales0123 added a commit that referenced this pull request Feb 28, 2022
@Zales0123
bug #373 Fix the build after #338 (Zales0123)
9dcba1c 
This PR was merged into the 1.9-dev branch.

Discussion
----------



Commits
-------

a7feab1 Fix the build
@loic425 loic425 mentioned this pull request Mar 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Roshyo Roshyo Roshyo approved these changes

@lchrusciel lchrusciel lchrusciel approved these changes

@Zales0123 Zales0123 Zales0123 approved these changes

@stloyd stloyd stloyd approved these changes

Assignees
No one assigned
Labels
DX Issues and PRs aimed at improving Developer eXperience. Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dannyvw @Roshyo @stloyd @Zales0123 @lchrusciel