-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move tests app #307
Move tests app #307
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similarly to ResourceBundle, we can move the spec
dir to the root directory too.
$ecsConfig->ruleWithConfiguration(HeaderCommentFixer::class, [ | ||
'location' => 'after_open', | ||
'header' => | ||
'This file is part of the Sylius package. | ||
|
||
(c) Paweł Jędrzejewski |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Rafikooo you should update licences in technical libs as well, shouldn't you?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, Lukasz, it will be another PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lchrusciel, sure! 🚀
Thank you, @loic425! |
No description provided.