Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move tests app #307

Merged
merged 3 commits into from
Jun 20, 2023
Merged

Move tests app #307

merged 3 commits into from
Jun 20, 2023

Conversation

loic425
Copy link
Member

@loic425 loic425 commented Jun 19, 2023

No description provided.

Copy link
Contributor

@jakubtobiasz jakubtobiasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly to ResourceBundle, we can move the spec dir to the root directory too.

$ecsConfig->ruleWithConfiguration(HeaderCommentFixer::class, [
'location' => 'after_open',
'header' =>
'This file is part of the Sylius package.

(c) Paweł Jędrzejewski
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rafikooo you should update licences in technical libs as well, shouldn't you?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, Lukasz, it will be another PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lchrusciel, sure! 🚀

@lchrusciel lchrusciel merged commit 55c4b83 into Sylius:1.13 Jun 20, 2023
@lchrusciel
Copy link
Member

Thank you, @loic425!

@loic425 loic425 deleted the move-tests-app branch June 20, 2023 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants