[GridBuilder] Add missing default value on filter #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loic425
changed the title
loic425
changed the title
loic425
force-pushed
the
feature/add-default-value-on-filter
branch
from
74eb0c3
to
037fa92
Compare
|
@loic425 I'm fine with this implementation. However, IMO the criteria should probably be marked as deprecated because it has the same purpose the default_value has but for a YAML-configured grid. |
lchrusciel
approved these changes
Nov 5, 2022
Roshyo
approved these changes
Nov 9, 2022
lchrusciel
added
Feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace #270