Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Api][Checkout] Add validation for required address #16063

Merged
merged 5 commits into from
Apr 2, 2024
Merged

[Api][Checkout] Add validation for required address #16063

merged 5 commits into from
Apr 2, 2024

Conversation

Wojdylak
Copy link
Member

Q A
Branch? 1.13
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets N/A
License MIT

@Wojdylak Wojdylak requested review from a team as code owners March 27, 2024 12:42
@probot-autolabeler probot-autolabeler bot added the API APIs related issues and PRs. label Mar 27, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 27, 2024 •
edited
Loading

Bunnyshell Preview Environment deleted

Available commands:

  • /bns:deploy to redeploy the environment

TheMilek
TheMilek previously approved these changes Mar 28, 2024
View reviewed changes
@Wojdylak Wojdylak mentioned this pull request Mar 29, 2024
Merged
GSadee
GSadee approved these changes Apr 2, 2024
View reviewed changes
tests/Api/Shop/CheckoutCompletionTest.php
}

/** @test */
public function it_does_not_allow_updating_without_require_billing_address(): void
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
public function it_does_not_allow_updating_without_require_billing_address(): void
public function it_does_not_allow_updating_without_required_billing_address(): void

tests/Api/Shop/CheckoutCompletionTest.php
}

/** @test */
public function it_does_not_allow_updating_without_require_shipping_address(): void
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
public function it_does_not_allow_updating_without_require_shipping_address(): void
public function it_does_not_allow_updating_without_required_shipping_address(): void

@GSadee GSadee merged commit 7e3503a into Sylius:1.13 Apr 2, 2024
28 checks passed
@GSadee
Copy link
Member

GSadee commented Apr 2, 2024

Thanks, Karol! 🥇

GSadee added a commit that referenced this pull request Apr 3, 2024
@GSadee
minor #16073 [API][Shop] Improve Order and Checkout tests (Wojdylak)
96fe9c4 
This PR was merged into the 1.13 branch.

Discussion
----------

| Q               | A                                                            |
|-----------------|--------------------------------------------------------------|
| Branch?         | 1.13
| Bug fix?        | no
| New feature?    | no
| BC breaks?      | no
| Deprecations?   | no
| Related tickets | N/A
| License         | MIT

Based on #16063

Commits
-------

ede8121 [Api][Shop] Add paymentNotFound validation to ChosenPaymentMethodEligibility class
ad53e3d [Api][Shop] Add Checkout/CartTest
1663553 [Api][Shop] Add Checkout/ShippingMethodTest
2791566 [Api][Shop] Add Checkout/PaymentMethodTest
1313080 [Api][Shop] Add Checkout/CompletionTest
833ac87 [Api][Shop] Improve orders tests
3b4f5eb Add nullable to phpstan type
da70b88 [API] Add respons for order item unit test
9f07f0c [API][Test] Add common response for different databases
324f430 [API][Test] Minor updating of functions name
@Wojdylak Wojdylak deleted the syl-3363-checkout-validation branch April 22, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rafikooo Rafikooo Rafikooo left review comments

@jakubtobiasz jakubtobiasz jakubtobiasz left review comments

@GSadee GSadee GSadee approved these changes

@TheMilek TheMilek TheMilek left review comments

Assignees
No one assigned
Labels
API APIs related issues and PRs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Wojdylak @GSadee @Rafikooo @TheMilek @jakubtobiasz