-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Api][Checkout] Add validation for required address #16063
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Wojdylak
commented
Mar 27, 2024
Q | A |
---|---|
Branch? | 1.13 |
Bug fix? | yes |
New feature? | no |
BC breaks? | no |
Deprecations? | no |
Related tickets | N/A |
License | MIT |
Bunnyshell Preview Environment deletedAvailable commands:
|
src/Sylius/Bundle/CoreBundle/Resources/translations/validators.en.yml
Outdated
Show resolved
Hide resolved
TheMilek
previously approved these changes
Mar 28, 2024
src/Sylius/Bundle/ApiBundle/Resources/config/validation/UpdateCart.xml
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/Validator/Constraints/OrderAddressRequirementValidator.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/spec/Validator/Constraints/OrderAddressRequirementValidatorSpec.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/spec/Validator/Constraints/OrderAddressRequirementValidatorSpec.php
Outdated
Show resolved
Hide resolved
TheMilek
previously approved these changes
Mar 28, 2024
Rafikooo
reviewed
Mar 31, 2024
src/Sylius/Bundle/ApiBundle/spec/Validator/Constraints/OrderAddressRequirementValidatorSpec.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/spec/Validator/Constraints/OrderAddressRequirementValidatorSpec.php
Outdated
Show resolved
Hide resolved
GSadee
reviewed
Apr 2, 2024
src/Sylius/Bundle/ApiBundle/Resources/config/services/validator.xml
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/spec/Validator/Constraints/OrderAddressRequirementValidatorSpec.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/Resources/translations/validators.en.yml
Outdated
Show resolved
Hide resolved
GSadee
approved these changes
Apr 2, 2024
} | ||
|
||
/** @test */ | ||
public function it_does_not_allow_updating_without_require_billing_address(): void |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
public function it_does_not_allow_updating_without_require_billing_address(): void | |
public function it_does_not_allow_updating_without_required_billing_address(): void |
} | ||
|
||
/** @test */ | ||
public function it_does_not_allow_updating_without_require_shipping_address(): void |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
public function it_does_not_allow_updating_without_require_shipping_address(): void | |
public function it_does_not_allow_updating_without_required_shipping_address(): void |
Thanks, Karol! 🥇 |
GSadee
added a commit
that referenced
this pull request
Apr 3, 2024
This PR was merged into the 1.13 branch. Discussion ---------- | Q | A | |-----------------|--------------------------------------------------------------| | Branch? | 1.13 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | N/A | License | MIT Based on #16063 Commits ------- ede8121 [Api][Shop] Add paymentNotFound validation to ChosenPaymentMethodEligibility class ad53e3d [Api][Shop] Add Checkout/CartTest 1663553 [Api][Shop] Add Checkout/ShippingMethodTest 2791566 [Api][Shop] Add Checkout/PaymentMethodTest 1313080 [Api][Shop] Add Checkout/CompletionTest 833ac87 [Api][Shop] Improve orders tests 3b4f5eb Add nullable to phpstan type da70b88 [API] Add respons for order item unit test 9f07f0c [API][Test] Add common response for different databases 324f430 [API][Test] Minor updating of functions name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.