[API] Cover adjustments serialization on OrderItemUnit and Shipment resources #15861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Wojdylak
commented
Feb 20, 2024
Wojdylak
commented
| Q | A |
|---|---|
| Branch? | 1.13 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | #15788 |
| License | MIT |
Bunnyshell Preview Environment deletedAvailable commands:
|
Wojdylak
force-pushed
the
SYL-3328-cover-adjustments-serialization-on-order-item-unit-and-shipment-resources
branch
from
fdb33f5
to
56f7b2b
Compare
Rafikooo
approved these changes
Feb 21, 2024
jakubtobiasz
approved these changes
Feb 22, 2024
diimpp
approved these changes
Feb 22, 2024
GSadee
approved these changes
Feb 22, 2024
|
|
||
| $response = $this->client->getResponse(); | ||
|
|
||
| $this->assertResponse($response, 'admin/order_item_units/get_order_item_unit_adjustments', Response::HTTP_OK); |
There was a problem hiding this comment.
Suggested change
| $this->assertResponse($response, 'admin/order_item_units/get_order_item_unit_adjustments', Response::HTTP_OK); | |
| $this->assertResponse($response, 'admin/order_item_units/get_adjustments', Response::HTTP_OK); |
It should be enough as the file is in order_item_units directory
|
|
||
| $response = $this->client->getResponse(); | ||
|
|
||
| $this->assertResponse($response, 'admin/shipment/get_shipment_adjustments', Response::HTTP_OK); |
There was a problem hiding this comment.
Suggested change
| $this->assertResponse($response, 'admin/shipment/get_shipment_adjustments', Response::HTTP_OK); | |
| $this->assertResponse($response, 'admin/shipment/get_adjustments', Response::HTTP_OK); |
|
Thank you, Karol! 🥇 |
Wojdylak
deleted the
SYL-3328-cover-adjustments-serialization-on-order-item-unit-and-shipment-resources
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.