Resolve comments #15843
Merged
Resolve comments #15843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheMilek
changed the title
TheMilek
force-pushed
the
resolve-comments
branch
from
28f0576
to
fdc26fc
Compare
Bunnyshell Preview Environment deletedAvailable commands:
|
| "orderPromotionTotal": 0, | ||
| "shippingPromotionTotal": 0 | ||
| }, | ||
| "order": "\/api\/v2\/shop\/orders\/token", |
There was a problem hiding this comment.
Suggested change
| "order": "\/api\/v2\/shop\/orders\/token", | |
| "order": "\/api\/v2\/shop\/orders\/@string@", |
unless the token is asserted anywhere.
A bit of a different problem here as well;
Why is the shop's item get on shop/order-items while changing quantity and removing is on shop/order/{token}/items/{id}?
TheMilek
force-pushed
the
resolve-comments
branch
3 times, most recently
from
a6cd025
to
c535002
Compare
Rafikooo
reviewed
Feb 15, 2024
src/Sylius/Bundle/ApiBundle/Resources/config/serialization/Adjustment.xml
Show resolved
Hide resolved
tests/Api/Responses/admin/order/get_order_item_unit_response.json
Outdated
Show resolved
Hide resolved
TheMilek
force-pushed
the
resolve-comments
branch
from
c535002
to
47b6476
Compare
Wojdylak
previously approved these changes
Feb 15, 2024
TheMilek
force-pushed
the
resolve-comments
branch
from
47b6476
to
ff50dee
Compare
Wojdylak
approved these changes
Feb 15, 2024
GSadee
approved these changes
Feb 15, 2024
Rafikooo
approved these changes
Feb 15, 2024
|
Thank you, @TheMilek! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #15788