Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump flex to ^1.17, v1.13 - old infrastructure shutdown #13933

Merged
merged 2 commits into from
May 12, 2022

Conversation

em411
Copy link
Contributor

@em411 em411 commented May 5, 2022

Q A
Branch? master
Bug fix? yes
New feature? yes
BC breaks? no
Deprecations? yes
Related tickets -
License MIT

https://symfony.com/blog/the-old-flex-infrastructure-is-shutting-down

@em411 em411 requested a review from a team as a code owner May 5, 2022 21:57
composer.json Outdated Show resolved Hide resolved
@Zales0123 Zales0123 changed the base branch from master to 1.10 May 12, 2022 08:46
@Zales0123
Copy link
Member

The base of this pull-request was changed, you need fetch and reset your local branch
if you want to add new commits to this pull request. Reset before you pull, else commits
may become messed-up.

Unless you added new commits (to this branch) locally that you did not push yet,
execute git fetch origin && git reset "patch-2" to update your local branch.

Feel free to ask for assistance when you get stuck 👍

@Zales0123
Copy link
Member

Hello @em411! I've allowed myself to change the PR to base on 1.10 branch and bump the flex constraint to 1.17.1 according to @stloyd comment. Thank you, for your contribution! 🎉

@Zales0123 Zales0123 added the Maintenance CI configurations, READMEs, releases, etc. label May 12, 2022
@em411
Copy link
Contributor Author

em411 commented May 12, 2022

Hi @Zales0123, sorry for the delay on my side, I didn't saw the response :)
Thanks for your help!

@lchrusciel lchrusciel merged commit 6f58e32 into Sylius:1.10 May 12, 2022
@lchrusciel
Copy link
Member

Thank you Emil! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance CI configurations, READMEs, releases, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants