Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bugfix][1.8] Kernel::configureContainer() should match it's parent signature #12185

Merged
merged 1 commit into from
Dec 22, 2020
Merged

[Bugfix][1.8] Kernel::configureContainer() should match it's parent signature #12185

merged 1 commit into from
Dec 22, 2020

Conversation

stloyd
Copy link
Contributor

@stloyd stloyd commented Dec 22, 2020

Q A
Branch? 1.8
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
License MIT

Error:

Argument 1 of App\Kernel::configureContainer has wrong name $c, expecting $container as defined by Symfony\Bundle\FrameworkBundle\Kernel\MicroKernelTrait::configureContainer

@stloyd stloyd requested a review from a team as a code owner December 22, 2020 10:44
@pamil pamil merged commit c80e9e1 into Sylius:1.8 Dec 22, 2020
@pamil
Copy link
Contributor

pamil commented Dec 22, 2020

Thank you, Joseph! 🥇

@stloyd stloyd deleted the patch-5 branch December 22, 2020 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pamil pamil pamil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stloyd @pamil