[Api]Add AddressDenormalizer #11693
Merged
[Api]Add AddressDenormalizer #11693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Tomanhez
commented
Jul 28, 2020
Tomanhez
commented
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | yes |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| License | MIT |
AdamKasp
reviewed
Jul 28, 2020
Tomanhez
force-pushed
the
address-serialization-fix
branch
2 times, most recently
from
72206bf
to
6d382aa
Compare
GSadee
reviewed
Jul 29, 2020
Tomanhez
force-pushed
the
address-serialization-fix
branch
from
6d382aa
to
58912cd
Compare
Tomanhez
force-pushed
the
address-serialization-fix
branch
from
58912cd
to
be5c59e
Compare
GSadee
approved these changes
Jul 29, 2020
GSadee
reviewed
Jul 30, 2020
GSadee
reviewed
Jul 30, 2020
Tomanhez
force-pushed
the
address-serialization-fix
branch
from
d4d5584
to
dc0c63d
Compare
GSadee
approved these changes
Jul 30, 2020
|
Thank you, Tomasz! 🥇 |
lchrusciel
reviewed
Aug 11, 2020
| @@ -28,6 +28,11 @@ | |||
| <import resource="services/validator.xml" /> | |||
| </imports> | |||
|
|
|||
| <parameters> | |||
| <parameter key="sylius.model.address.class.api.denormalize">%sylius.model.address.class%</parameter> | |||
| <parameter key="sylius.model.address.interface.api.denormalize">Sylius\Component\Core\Model\AddressInterface</parameter> | |||
There was a problem hiding this comment.
Suggested change
| <parameter key="sylius.model.address.interface.api.denormalize">Sylius\Component\Core\Model\AddressInterface</parameter> | |
| <parameter key="sylius.model.address.interface.api.denormalize">%sylius.model.address.interface.class%</parameter> |
Therefore we could even remove these custom parameters, as we have everything from Resource. The drawback of this solution is that we will need to make type hints to the first class in the interface chain. On the contrary, it will work exactly the same as in Doctrine Mapping. In addition, we could make it work for all Sylius resource out-of-the-box.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.