Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[API] add locale to Api Platform #11273

Merged
merged 1 commit into from
Mar 23, 2020
Merged

[API] add locale to Api Platform #11273

merged 1 commit into from
Mar 23, 2020

Conversation

oallain
Copy link
Member

@oallain oallain commented Mar 22, 2020

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Related tickets partially #11250
License MIT

Locales

  • All the features from features/locale/managing_locales
  • 2 scenarios / 3 files
  • Create an index action only (show may be required as well)

@oallain oallain requested a review from a team as a code owner March 22, 2020 18:19
@oallain oallain changed the title add locale to Api Platform [API] add locale to Api Platform Mar 22, 2020
@Zales0123 Zales0123 added API APIs related issues and PRs. Feature New feature proposals. labels Mar 22, 2020
Zales0123
Zales0123 reviewed Mar 22, 2020
View reviewed changes
Copy link
Member

@Zales0123 Zales0123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Olivier, very much for this contribution! 🖖

src/Sylius/Behat/Context/Api/Admin/ManagingLocalesContext.php Outdated Show resolved Hide resolved
src/Sylius/Behat/Context/Api/Admin/ManagingLocalesContext.php Outdated Show resolved Hide resolved
src/Sylius/Behat/Resources/config/services/api.xml Outdated Show resolved Hide resolved
@Zales0123 Zales0123 merged commit 8cb3f3d into Sylius:master Mar 23, 2020
@Zales0123
Copy link
Member

Thank you, @oallain! 🥇

@oallain oallain deleted the api-locale branch March 24, 2020 07:44
@lchrusciel lchrusciel mentioned this pull request Mar 24, 2020
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zales0123 Zales0123 Zales0123 approved these changes

Assignees
No one assigned
Labels
API APIs related issues and PRs. Feature New feature proposals.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oallain @Zales0123