Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Improved coping UX #11135

Merged
merged 1 commit into from
Apr 2, 2020
Merged

[Docs] Improved coping UX #11135

merged 1 commit into from
Apr 2, 2020

Conversation

lchrusciel
Copy link
Member

Q A
Branch? master
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets
License MIT

Recently we have added the possibility to copy code from our documentation. Removing $ from command line examples is annoying as hell.

@lchrusciel lchrusciel requested a review from a team as a code owner February 24, 2020 12:32
@Zales0123 Zales0123 added Documentation Documentation related issues and PRs - requests, fixes, proposals. UX Issues and PRs aimed at improving User eXperience. labels Feb 24, 2020
@@ -84,7 +84,7 @@ Sylius Plus provides a route that allows changing inventory source stock with an

.. code-block:: bash

$ POST /api/v1/inventory-sources/{code}/update-stocks
POST /api/v1/inventory-sources/{code}/update-stocks
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be updated and curl should be used

@@ -1,143 +0,0 @@
Installation
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is wrong and it is ok, that it is removed

@pamil pamil changed the base branch from master to 1.7 February 25, 2020 15:04
@pamil
Copy link
Contributor

pamil commented Feb 25, 2020

The base of this pull-request was changed, you need fetch and reset your local branch
if you want to add new commits to this pull request. Reset before you pull, else commits
may become messed-up.

Unless you added new commits (to this branch) locally that you did not push yet,
execute git fetch origin && git reset "improve-docs" to update your local branch.

Feel free to ask for assistance when you get stuck 👍

@pamil pamil merged commit 7b728f4 into Sylius:1.7 Apr 2, 2020
@pamil
Copy link
Contributor

pamil commented Apr 2, 2020

Thank you, Łukasz! 🎉

@lchrusciel lchrusciel deleted the improve-docs branch April 2, 2020 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Documentation related issues and PRs - requests, fixes, proposals. UX Issues and PRs aimed at improving User eXperience.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants