Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Behat] Rework testing product reviews to use test attributes #11101

Merged
merged 3 commits into from
Feb 7, 2020
Merged

[Behat] Rework testing product reviews to use test attributes #11101

merged 3 commits into from
Feb 7, 2020

Conversation

GSadee
Copy link
Member

@GSadee GSadee commented Feb 6, 2020

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Related tickets
License MIT

@GSadee GSadee added DX Issues and PRs aimed at improving Developer eXperience. Behat Issues and PRs aimed at improving Behat usage. labels Feb 6, 2020
@GSadee GSadee requested a review from a team as a code owner February 6, 2020 13:48
@GSadee GSadee force-pushed the product-reviews-test-attributes branch from 0e27338 to c07fddd Compare February 6, 2020 14:40
@GSadee GSadee force-pushed the product-reviews-test-attributes branch from c07fddd to 9a345af Compare February 7, 2020 09:29
@GSadee GSadee force-pushed the product-reviews-test-attributes branch from 9a345af to 238ab95 Compare February 7, 2020 11:47
@lchrusciel lchrusciel merged commit 1769816 into Sylius:master Feb 7, 2020
@lchrusciel
Copy link
Member

Thanks, Grzegorz! 🎉

@GSadee GSadee deleted the product-reviews-test-attributes branch February 7, 2020 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tomanhez Tomanhez Tomanhez approved these changes

@AdamKasp AdamKasp AdamKasp approved these changes

@kulczy kulczy kulczy approved these changes

@lchrusciel lchrusciel lchrusciel approved these changes

Assignees
No one assigned
Labels
Behat Issues and PRs aimed at improving Behat usage. DX Issues and PRs aimed at improving Developer eXperience.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@GSadee @lchrusciel @kulczy @AdamKasp @Tomanhez