Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Sonata Block Bundle ^4.0 #10984

Merged
merged 1 commit into from
Jan 15, 2020
Merged

Upgrade to Sonata Block Bundle ^4.0 #10984

merged 1 commit into from
Jan 15, 2020

Conversation

pamil
Copy link
Contributor

@pamil pamil commented Dec 23, 2019

Related to #10928.

@pamil pamil requested a review from a team as a code owner December 23, 2019 10:27
@Zales0123
Copy link
Member

Zales0123 commented Dec 27, 2019 •
edited
Loading

As far as I see, Sonata Block Bundle ^4.0 requires PHP7.3, so our tests on 7.2 fail:/ Is it even possible for us to support both these versions and still make progress with Symfony 5?

@pamil pamil added the Maintenance CI configurations, READMEs, releases, etc. label Jan 15, 2020
@Zales0123 Zales0123 merged commit c6c828f into Sylius:master Jan 15, 2020
@Zales0123
Copy link
Member

Thank you, Kamil! 🎉

@pamil pamil deleted the sonata-block-4 branch January 15, 2020 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdamKasp AdamKasp AdamKasp approved these changes

@Zales0123 Zales0123 Zales0123 approved these changes

Assignees
No one assigned
Labels
Maintenance CI configurations, READMEs, releases, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pamil @Zales0123 @lchrusciel @AdamKasp