Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation][Cookbook] How to add Google Analytics script to shop? #10902

Merged
merged 2 commits into from
Dec 6, 2019

Conversation

AdamKasp
Copy link
Contributor

@AdamKasp AdamKasp commented Dec 4, 2019

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
License MIT

@AdamKasp AdamKasp requested a review from a team as a code owner December 4, 2019 10:26
@CoderMaggie CoderMaggie added the Documentation Documentation related issues and PRs - requests, fixes, proposals. label Dec 4, 2019
@AdamKasp AdamKasp changed the title [WIP] Google Analytics cookbook Google Analytics cookbook Dec 4, 2019
@CoderMaggie CoderMaggie changed the title Google Analytics cookbook [Documentation][Cookbook] How to add Google Analytics script to shop? Dec 4, 2019
docs/cookbook/frontend/google-analitics.rst Outdated Show resolved Hide resolved
docs/cookbook/frontend/google-analitics.rst Outdated Show resolved Hide resolved
docs/cookbook/frontend/google-analitics.rst Outdated Show resolved Hide resolved
docs/cookbook/frontend/google-analitics.rst Outdated Show resolved Hide resolved
docs/cookbook/frontend/google-analitics.rst Outdated Show resolved Hide resolved
docs/cookbook/frontend/google-analitics.rst Outdated Show resolved Hide resolved
docs/cookbook/frontend/google-analitics.rst Outdated Show resolved Hide resolved
docs/cookbook/frontend/google-analytics.rst Outdated Show resolved Hide resolved
docs/cookbook/frontend/google-analytics.rst Outdated Show resolved Hide resolved
docs/cookbook/frontend/google-analytics.rst Outdated Show resolved Hide resolved
docs/cookbook/frontend/google-analytics.rst Outdated Show resolved Hide resolved
docs/cookbook/frontend/google-analytics.rst Outdated Show resolved Hide resolved
docs/cookbook/frontend/google-analytics.rst Outdated Show resolved Hide resolved
docs/cookbook/frontend/google-analytics.rst Outdated Show resolved Hide resolved
docs/cookbook/frontend/google-analytics.rst Outdated Show resolved Hide resolved
docs/cookbook/frontend/google-analytics.rst Outdated Show resolved Hide resolved
@AdamKasp AdamKasp force-pushed the google-analitics-cookbook branch 3 times, most recently from ce64cc8 to e88f4e2 Compare December 5, 2019 12:52
Adding Google Analytics by pasting the script directly into the layout template.
--------------------------------------------------------------------------------

If you want to add Google Analytics by this way, you need to override the ``layout.html.twig`` in ``Resources/templates/bundles/SyliusShopBundle/``.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't see any Resources directory in Sylius-Standard.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If you want to add Google Analytics by this way, you need to override the ``layout.html.twig`` in ``Resources/templates/bundles/SyliusShopBundle/``.
If you want to add Google Analytics by this way, you need to override the ``layout.html.twig`` in ``templates/bundles/SyliusShopBundle/layout.html.twig``.

.. code-block:: twig

{# Resources/templates/bundles/SyliusShopBundle/layout.html.twig #}
{# ... #}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I copy the contents of the original layout here?

docs/cookbook/frontend/google-analytics.rst Outdated Show resolved Hide resolved
@GSadee GSadee merged commit 57d90d8 into Sylius:master Dec 6, 2019
@GSadee
Copy link
Member

GSadee commented Dec 6, 2019

Thank you, Adam! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Documentation related issues and PRs - requests, fixes, proposals.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants