Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cart flow documented #10167

Merged
merged 2 commits into from
Feb 14, 2019
Merged

Cart flow documented #10167

merged 2 commits into from
Feb 14, 2019

Conversation

bartoszpietrzak1994
Copy link
Contributor

Q A
Branch? 1.3
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets related to #8370
License MIT

@bartoszpietrzak1994 bartoszpietrzak1994 requested review from CoderMaggie and a team February 11, 2019 15:30
CoderMaggie
CoderMaggie requested changes Feb 12, 2019
View reviewed changes
docs/book/orders/cart-flow.rst Outdated Show resolved Hide resolved
docs/book/orders/cart-flow.rst Outdated Show resolved Hide resolved
docs/book/orders/cart-flow.rst Outdated Show resolved Hide resolved
docs/book/orders/index.rst Outdated Show resolved Hide resolved
@CoderMaggie CoderMaggie added the Documentation Documentation related issues and PRs - requests, fixes, proposals. label Feb 12, 2019
CoderMaggie
CoderMaggie reviewed Feb 12, 2019
View reviewed changes
Copy link
Member

@CoderMaggie CoderMaggie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was imagining rather of more descriptive scenarios, with like you know, "This user adds a yellow t-shirt into his cart" :D

But for now it looks okay, just have a look at these two comments :)

docs/book/orders/cart-flow.rst Outdated Show resolved Hide resolved
docs/book/orders/cart-flow.rst Show resolved Hide resolved
pamil
pamil reviewed Feb 14, 2019
View reviewed changes
docs/book/orders/cart-flow.rst
=========

**Cart** in Sylius is an **Order** in the state ``cart``.
It represents an order that is in progress (not placed yet).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would go with It represents an order that is not placed yet

@bartoszpietrzak1994 bartoszpietrzak1994 force-pushed the cart-flow-documentation branch 2 times, most recently from 0fef7b4 to dcfa415 Compare February 14, 2019 11:15
CoderMaggie
CoderMaggie approved these changes Feb 14, 2019
View reviewed changes
Copy link
Member

@CoderMaggie CoderMaggie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is lovely now <3

@pamil pamil merged commit 621a2ed into Sylius:1.3 Feb 14, 2019
@pamil
Copy link
Contributor

pamil commented Feb 14, 2019

Thanks, Bartosz! 🎉

@CoderMaggie CoderMaggie mentioned this pull request Feb 18, 2019
Closed
@Zales0123 Zales0123 mentioned this pull request Mar 1, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pamil pamil pamil left review comments

@CoderMaggie CoderMaggie CoderMaggie approved these changes

Assignees
No one assigned
Labels
Documentation Documentation related issues and PRs - requests, fixes, proposals.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bartoszpietrzak1994 @pamil @CoderMaggie