#9699 Fix for viewing products when they belong to a taxon and to one… #10070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to one of children taxon
laurent35240
force-pushed
the
9699_productPaginationFix
branch
from
9c02892
to
94b8a15
Compare
CoderMaggie
added
the
Potential Bug
lchrusciel
approved these changes
Jan 7, 2019
bartoszpietrzak1994
approved these changes
Jan 7, 2019
|
@lchrusciel Is it in the behat scenario that you'd like to have a product with translation? |
|
@laurent35240 I think that is what @lchrusciel meant. Maybe we should check if adding the distinct clause does not affect joining the translations table in any way. |
|
Yup. I prefer to ensure, that we are not adding any regression. However, there should be some tests for that anyway. |
pamil
reviewed
Jan 9, 2019
features/product/viewing_products/viewing_products_from_taxon_and_children.feature
Outdated
Show resolved
Hide resolved
| @@ -70,6 +70,7 @@ public function createShopListQueryBuilder( | |||
| array $sorting = [] | |||
| ): QueryBuilder { | |||
| $queryBuilder = $this->createQueryBuilder('o') | |||
| ->distinct() | |||
There was a problem hiding this comment.
It's so simple when you see it, but couldn't figure it out when I was trying to solve this issue, good job 🎉
pamil
approved these changes
Jan 13, 2019
|
Thank you, Laurent! 🎉 |
lchrusciel
added a commit
to lchrusciel/Sylius
that referenced
this pull request
Jan 31, 2019
lchrusciel
added a commit
that referenced
this pull request
Jan 31, 2019
This PR was merged into the 1.2 branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | 1.2 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | introduced in #10070, replaces #10114 and #10134, fixes #7389 | License | MIT Based on a PR by @yohang (thank you for your work!). The test was failing, as there is another bug with setting max results with paginator (that's why I've reduced the amount of products in the scenario) 🚀 😄 But the 500 error bug is fixed (I've also checked it manually). Commits ------- e229211 Added productTaxon to product list query to prevent an SQL error 261236e Quick fix for the scenario
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… of children taxon