Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused Behat method #10065

Merged
merged 1 commit into from
Jan 3, 2019
Merged

Remove unused Behat method #10065

merged 1 commit into from
Jan 3, 2019

Conversation

Zales0123
Copy link
Member

Q A
Branch? 1.2
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets
License MIT

It was alone, not needed by anybody 😢

@Zales0123 Zales0123 added Potential Bug Potential bugs or bugfixes, that needs to be reproduced. Behat Issues and PRs aimed at improving Behat usage. labels Jan 3, 2019
@Zales0123 Zales0123 requested a review from a team as a code owner January 3, 2019 14:13
@pamil
Copy link
Contributor

pamil commented Jan 3, 2019

I believe the target branch is wrong :)

@Zales0123 Zales0123 changed the base branch from master to 1.2 January 3, 2019 14:21
@Zales0123
Copy link
Member Author

shame

@lchrusciel lchrusciel merged commit e3f001c into Sylius:1.2 Jan 3, 2019
@lchrusciel
Copy link
Member

Thank you, Mateusz! 🎉

@Zales0123 Zales0123 deleted the behat-clean-up branch January 3, 2019 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartoszpietrzak1994 bartoszpietrzak1994 bartoszpietrzak1994 approved these changes

@lchrusciel lchrusciel lchrusciel approved these changes

@pamil pamil pamil approved these changes

Assignees
No one assigned
Labels
Behat Issues and PRs aimed at improving Behat usage. Potential Bug Potential bugs or bugfixes, that needs to be reproduced.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Zales0123 @pamil @lchrusciel @bartoszpietrzak1994