Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI] Remove import with redundant macro #402

Merged
merged 2 commits into from
Feb 22, 2023
Merged

[UI] Remove import with redundant macro #402

merged 2 commits into from
Feb 22, 2023

Conversation

coldic3
Copy link
Contributor

@coldic3 coldic3 commented Feb 21, 2023

Q A
Branch? 1.3
Bug fix? no
New feature? no
Related tickets

The money macro is not used.

@coldic3 coldic3 requested a review from a team as a code owner February 21, 2023 15:35
@coldic3 coldic3 marked this pull request as draft February 21, 2023 15:36
@coldic3 coldic3 changed the title [UI] Fix money macro context [UI] Remove import with redundant macro Feb 21, 2023
@coldic3 coldic3 marked this pull request as ready for review February 21, 2023 16:00
jakubtobiasz
jakubtobiasz approved these changes Feb 22, 2023
View reviewed changes
Copy link
Contributor

@jakubtobiasz jakubtobiasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Theoretically, .env changes in the test app should go as a separate PR, but I'm fine with that if nobody more raises this issue 🖖🏼.

@NoResponseMate NoResponseMate merged commit 4a35257 into Sylius:1.3 Feb 22, 2023
@NoResponseMate
Copy link
Contributor

Thank you, @coldic3!

@GSadee GSadee added the Maintenance Configurations, READMEs, releases, etc. label Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NoResponseMate NoResponseMate NoResponseMate approved these changes

@jakubtobiasz jakubtobiasz jakubtobiasz approved these changes

Assignees
No one assigned
Labels
Maintenance Configurations, READMEs, releases, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@coldic3 @NoResponseMate @jakubtobiasz @GSadee