[Maintenance] Add support for Sylius 1.12 with Symfony 5.4 #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coldic3
force-pushed
the
sylius1.12-symfony5.4
branch
7 times, most recently
from
90badd7
to
7baf50f
Compare
Merged
jakubtobiasz
approved these changes
Oct 18, 2022
GSadee
approved these changes
Oct 20, 2022
Co-authored-by: Jakub Tobiasz <[email protected]>
coldic3
force-pushed
the
sylius1.12-symfony5.4
branch
from
82ea050
to
2254fef
Compare
coldic3
changed the title
GSadee
approved these changes
Nov 2, 2022
| @@ -23,7 +23,7 @@ | |||
| "knplabs/knp-snappy-bundle": "^1.7", | |||
| "myclabs/php-enum": "^1.7", | |||
| "sylius/resource-bundle": "^1.6", | |||
| "sylius/sylius": "~1.11.4", | |||
| "sylius/sylius": "~1.11.4 || ~1.12.0", | |||
There was a problem hiding this comment.
Suggested change
| "sylius/sylius": "~1.11.4 || ~1.12.0", | |
| "sylius/sylius": "^1.11.4", |
but I'm not sure if your version isn't more explicit 🤔
|
Thank you, Kevin! 🥇 |
GSadee
added a commit
that referenced
this pull request
Nov 8, 2022
This PR was merged into the 1.3 branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | 1.3 | Bug fix? | no | New feature? | no | Related tickets | To be merged on Sylius 1.12 release 💃 In addition, #385 should be merged before this one then the rebase will be needed. Commits ------- 124da5b [GitHub Actions] Add Sylius 1.12 to the matrix 69d029f [Maintenance] Add support for Symfony 6 abf9148 [Maintenance] Fix Kernel.php and app configs 5483b16 [Maintenance] Adjust services to Sylius 6 006c863 [Maintenance] Fix deprecated services definitions 726ccf1 [Maintenance] Upgrade PHPStan packages 6ca616b [GitHub Actions] Bump node version e79164a Add missing deprecation fb14324 [GitHub Actions] Add more elements to the matrix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be merged on Sylius 1.12 release 💃
Support for Symfony 6 will be added in a separate PR.