Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Duplicate images are saved as separate files GFPGAN + RealESRGAN + Regular. NEED A FIX |details inside| #189

Closed
search620 opened this issue Aug 28, 2022 · 3 comments

Comments

@search620
Copy link

The images are saved separately although the setting is only for specific parameters.

For example:
I want generate images with GFPGAN + RealESRGAN but I do not need them to save separately for each model I need them to merge to one image.

So basically the correction need to be for export images as one per specific parameters.
Like if I choose to use the upscale and the face correction so I want the end results to be one image and not 3

@hlky
Copy link
Contributor

hlky commented Aug 28, 2022

This was already fixed f19029a

Also see https://github.com/hlky/stable-diffusion-webui/wiki/Upscalers

Just do your post-processing as post-processing, this is why these features are going to be removed from on generation, it's causing far too many issues for something that isn't really needed because you don't actually need to run gfpgan and esrgan on every single image you generate, and you dont know if you need to run it until after the image is generated

NEED A FIX

Please avoid this kind of language, it is disrespectful

@hlky hlky closed this as completed Aug 28, 2022
@ZeroCool940711
Copy link
Contributor

ZeroCool940711 commented Aug 28, 2022

@hlky I don't understand why you say upscaling and face fixing is not needed during generation and has to be done during post-processing, I personally do like those things done during generation as I do not want to do any post-processing and I just want to go to the output folder or go through the images on the mage and find the ones I like as they are and use them as they are, if I don't like how some images are I can just run another generation and get 100+ more images but if I have to process every image manually to fix the face and then upscale them so I can see how they look after that then I will most likely not do any of that and never use those features as it will be a waste of time, and btw, I've been able to create about 300 wallpapers with this tool as it is just because it has the upscaling done automatically after the generation to get high resolution images easily and I can just focus on generating a big batch of images and then pick the one I like and that's it, and I've used this tool not only for generating wallpapers but also for a lot of other stuff, from logos, sketches and ideas for drawing, also faces used on reviews on a website I have that I was in need of some basic faces for the main page, also used this to generate the background image of that website, it isn't yet made public or otherwise I would just share a link to it for you to see but just letting you know that this has a lot of uses. I'm pretty sure other people like to do the same thing and use the UI as it is with things done automatically as it's faster and easier to experiment with things that way, it would be better to leave things the way they are even if they are sometimes broken instead of just removing the upscaling and face fixing from generation to post-processing as that will most likely kill those features for most users that do want to use them but can't bother to waste time doing things manually.

@search620
Copy link
Author

Well sorry for my language I do not attempt to be disrespectful to anyone I just pointed out the fix that I think should have been because it makes it confusing to understand what is what.

I will suggest maybe adding an option for the user for exporting.
Meaning the user will have the option to export as separate files\generation or to choose to export as one merge file (png).
That would be very useful.

And as you can see there are users who want the option to use face correction or upscale (as I am too) so I do not think you should remove them. maybe they do not need another tab for themself because it creates confusion for some users.
(That's not the main problem for now)

Certainly, they should be present within the option of advanced.

I hope I am clear and if not then I would be happy to clarify so please feel free to note me.

Thanks a lot!!!! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants