-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Remove Newlines" filter #47
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK except indentation
Sources/Environment.swift
Outdated
registerFilter("lowerFirstWord", filter: Filters.Strings.lowerFirstWord) | ||
registerFilter("removeNewlines", filter: Filters.Strings.removeNewlines) | ||
registerFilter("snakeToCamelCase", filter: Filters.Strings.snakeToCamelCase) | ||
registerFilter("swiftIdentifier", filter: Filters.Strings.stringToSwiftIdentifier) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use spaces for indentation to be consistent with the rest of the code
Sources/Filters+Strings.swift
Outdated
let result = string.components(separatedBy: set).joined() | ||
|
||
return result | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use 2-space indentation
238cac6
to
d3d53bc
Compare
d3d53bc
to
d3c984b
Compare
Fixes #23.
The removal of spaces can be controlled via a boolean parameter, by default (true) it removes spaces.