Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change our filters to accept a mode parameter instead of a boolean. #100

Open
djbe opened this issue Sep 4, 2018 · 0 comments
Open

Change our filters to accept a mode parameter instead of a boolean. #100

djbe opened this issue Sep 4, 2018 · 0 comments
Milestone
Next Major

Comments

@djbe
Copy link
Member

djbe commented Sep 4, 2018 •
edited
Loading

Some of our current filters accept a boolean parameter, which isn't always clear "what" that parameter is for:

  • camelToSnakeCase: lowercase the components or not
  • snakeToCamelCase: trim empty components

For some of our other filters, we already use a "mode" string parameter, that says a bit more about what it does:

  • removeNewlines: all or leading
  • swiftIdentifier: normal or pretty

Suggestions for modes:

  • camelToSnakeCase: lowercase or none
  • snakeToCamelCase: trim-empty or none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Next Major
Development

No branches or pull requests
1 participant
@djbe