Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/reader nav bar scroll to page #236

Merged
merged 4 commits into from
Feb 12, 2023
Merged

Fix/reader nav bar scroll to page #236

merged 4 commits into from
Feb 12, 2023

Conversation

schroda
Copy link
Collaborator

@schroda schroda commented Feb 11, 2023

No description provided.

Using "curPage" as the "initialPage" broke "scrolling up".
The page got reset to the first page in that case
Due to handling the overflow on the "root" div and the "nav bar" being sticky and having a combined with of 100vw with the "vertical pager", once the first page was reached, that was behind the 100vw, the "nav bar" got moved out of the screen.
This made using the "nav bar" unusable for the "vertical pager".
@AriaMoradi AriaMoradi merged commit ad9a12b into Suwayomi:master Feb 12, 2023
@schroda schroda deleted the fix/reader_nav_bar_scroll_to_page branch February 25, 2023 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants