refactor ChapterOptions #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ff2400t
commented
Jan 22, 2022
ff2400t
commented
- Added useReducerLocalStorage
- Moved the Logic of ChapterOptions to a reducer
- Moved the filter logic from ChapterList to seperate util file
- Moved the ResumeFAB to seperate file
This is mostly a refactor of ChapterOptions to simplify it with a reducer function Also moved a lot of function used in ChaperList to a utility file
AriaMoradi
requested changes
Jan 22, 2022
… chapterOption prefix
AriaMoradi
requested changes
Jan 23, 2022
AriaMoradi
changed the title
ff2400t
force-pushed
the
options-refactor
branch
from
9bcf71c
to
fd9e12d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.