Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Add linux-all.tar.gz #302

Closed
mahor1221 opened this issue Mar 3, 2022 · 6 comments · Fixed by #366
Closed

[Feature Request] Add linux-all.tar.gz #302

mahor1221 opened this issue Mar 3, 2022 · 6 comments · Fixed by #366
Labels
enhancement New feature or request

Comments

@mahor1221
Copy link
Contributor

mahor1221 commented Mar 3, 2022

What feature should be added to Tachidesk?

Consider adding Tachidesk-Server-v<ver>-r<rev num>-linux-all.tar.gz that contains:

tachidesk-server-browser-launcher.sh
tachidesk-server-debug-launcher.sh
tachidesk-server-electron-launcher.sh
tachidesk-server.desktop
tachidesk-server.png
tachidesk-server.jar

And remove Tachidesk-Server-v<ver>-r<rev num>-linux-x64.tar.gz If it's not needed?

Why/Project's Benefit/Existing Problem

It makes doing universal changes to AUR, MPR, PPA and other possible future packages ( NixPkg and RPM ) a lot easier.

@mahor1221 mahor1221 added the enhancement New feature or request label Mar 3, 2022
@mahor1221
Copy link
Contributor Author

I can add it if you want

@AriaMoradi
Copy link
Member

Making a flatpak for universal distro support is better

We could very much do your proposal but the scripts need to be changed a bit and check for java/electron executable availablity

@mahor1221
Copy link
Contributor Author

I didn't mean to say using it as way of supporting a lot of distros. It's like a replacement for plain Tachidesk-Server-*.jar in release section so I can make AUR, MPR and PPA more automated and put less time on updating them. Also the compressed tar.gz file is about 10% smaller.

Electron launcher script checks for electron availability in AUR and various deb packages so it's not like we are not doing it already.

@AriaMoradi
Copy link
Member

AriaMoradi commented Mar 3, 2022

Tachidesk-Server-v<ver>-r<rev num>-linux-all.tar.gz means any cpu architecture(in our naming scheme) and it could potentially support any distro, why not have it?

so I can make AUR, MPR and PPA more automated and put less time on updating them

Why don't you make CI scripts for automatic updating? I had the idea for the tachidesk-preview AUR package and even made an account ArMor007Bot for automation

@mahor1221
Copy link
Contributor Author

Tachidesk-Server-v-r-linux-all.tar.gz means any cpu architecture(in our naming scheme) and it could potentially support any distro, why not have it?

Could you clarify a little I wasn't able to understand completely. Does "it" refer to Flatpack? If it does then Yeah sure I think me or somebody else can make a Flatpack someday. but it's not related to my request.

Why don't you make CI scripts for automatic updating? I had the idea for the tachidesk-preview AUR package and even made an account ArMor007Bot for automation

That's really cool I'll definitely check how did you do it 👍. but the bot and the tar.gz file can coexist.

I've deployed the Idea in Tachidesk-Sorayomi. Icon and desktop file are included in the tar.gz archive. Its icon has changed today and the AUR package's icon changed too without manual intervention. In the case of Tachidesk-Server where I have to update the package across four different platforms manually a tar.gz archive has a lot more value and this is not something I can do with a bot easily.

@AriaMoradi
Copy link
Member

That can work, make a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants