Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Unable to handle Filter.Select properly with some sources #300

Closed
Syer10 opened this issue Feb 28, 2022 · 0 comments · Fixed by #347
Closed

[Bug] Unable to handle Filter.Select properly with some sources #300

Syer10 opened this issue Feb 28, 2022 · 0 comments · Fixed by #347
Labels
bug Something isn't working

Comments

@Syer10
Copy link
Collaborator

Syer10 commented Feb 28, 2022

Steps to reproduce

  1. Use Tachidesk-JUI which has support for filters
  2. Open Flame Scans

Expected behavior

Filters should be visible

Actual behavior

Filters are not visible

Other details

Filter.Select has a generic type that is most of the time a String, but some sources use custom objects.
JUI uses the string to display the select option, while Tachi uses the Any.toString() method

Proposed solution

Encode the Select json with another field that JUI and other clients can use for the display name

@Syer10 Syer10 added the bug Something isn't working label Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant