Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Add an option to disable particles from certain sources #18

Open
OrigamingWasTaken opened this issue Nov 16, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@OrigamingWasTaken
Copy link

Hi! I love the mod and I think it's very nice.
Sadly I can't really use it because I play Crystal Pvp, and the particles are blocking my view (an average of 10 crystal explosions per second)

It would be nice to see this option!

@Superkat32
Copy link
Owner

I think this would be a nice option as well. I'm not completely sure right away how it could be executed well, but I'm pretty sure it is possible code-wise(somebody sent me a video one day with the underwater explosion activating from a charged creeper explosion, so that's that). I'm not sure when I'll get started on this, but I think it would be beneficial in the long run(because it would also mean I could have a special explosion effect for something like an end crystal).

I seem to keep accidentally overlooking the needs of crystal pvp players(most likely because I haven't touched pvp at all in forever now), so if there is something else you'd like to see changed in any of my mods for better crystal pvp accessibility, please let me know!

@Superkat32 Superkat32 added the enhancement New feature or request label Nov 16, 2023
@Superkat32 Superkat32 self-assigned this Nov 16, 2023
@LegendaryLilac
Copy link

what about reducing opacity?

@Superkat32
Copy link
Owner

With 1.21 coming soon, I have finally gotten around to this. Unfortunately though, it simply isn't possible. The entity data for the explosion's source is never sent to the client. I can't do anything about it without the mod being installed on the server, which is unlikely to happen or help in a pvp server environment(unless you manage the server). Simply one of the limitations of working exclusively on the client side.

While that means this issue(and #33 ) will be marked as won't fix, I am willing to try and add a few compromises. I have a few ideas and would like to hear your guys' ideas as well. My ideas are:

  • Ability to change the explosion's size in addition power. Perhaps a multiplier(e.g. 0.25 for a quarter of the size)
  • Ability to change the explosion's opacity.
  • Hotkey to enable/disable the mod(set to nothing by default)

I could also add an option to disable the explosion if it is a specific power. Unless modified by the server, an end crystal's explosion power is always 6.0. While this isn't a guaranteed way to disable from a specific source, it could help to some degree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants