Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

esp-open-rtos ads1115 not working config errors #764

Open
s5y3XZpGvQPApqR opened this issue Oct 21, 2020 · 0 comments
Open

esp-open-rtos ads1115 not working config errors #764

s5y3XZpGvQPApqR opened this issue Oct 21, 2020 · 0 comments

Comments

@s5y3XZpGvQPApqR
Copy link

Per the datasheet:

esp-open-rtos/extras/ads111x/ads111x.c Line 24 see datasheet page 19
#define COMP_QUE_OFFSET should be 0 not 1

esp-open-rtos/extras/ads111x/ads111x.c Lines 54-61 see datasheet page 11 "Read Conversion register:"
in read_reg byte order returned from i2c_slave_read in res is different endianess to uint16_t and needs swapping e.g.
res = ((res & 0xff) << 8) | (res >> 8);

You might update the comment in esp-open-rtos/examples/ads1115_test/main.c to refer to the ADS111x not DS1302 RTC driver

Keep up the good work. Thanks in advance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant