Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When playing preroll ads, sometimes the text appears very small #26

Open
DoomTay opened this issue May 30, 2018 · 0 comments
Open

When playing preroll ads, sometimes the text appears very small #26

DoomTay opened this issue May 30, 2018 · 0 comments

Comments

@DoomTay
Copy link
Contributor

DoomTay commented May 30, 2018

Sample set

This happens with a simple implementation of videojs-contrib-ads (heisenbug.html) and with videojs-vast-vpaid (heisenbug2.html), though the latter case is much, much rarer.

This happens the most when the video doesn't autoplay, but bizarrely, adding a new subtitle track somehow fixes it.

I brought this up in the libjass repository and the main project leader had this to say

videojs-ass is starting the clock before calling resize, thus WebRenderer.preRender is getting called before its scaleX and scaleY properties have been initialized. videojs-ass needs to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant