Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue SB-30516 chore: Updated to new sunbird video player & video.js … #8210

Closed

Conversation

Xitija
Copy link
Contributor

@Xitija Xitija commented Aug 3, 2022

… package in package.json

PR for this change is being done for the purpose of testing of the new Sunbird video player package .
It will be reqiured as QA will get a platform to perform the testing.
PR will be reverted when the testing is completed.

Just wanted to know when the PR will be merged where can we see the changes on
dev.sunbirded.org or staging.sunbirded.org ?

@coolbung @baljeetsingh @vinukumar-vs @HarishGangula

@sonarcloud
Copy link

sonarcloud bot commented Aug 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Xitija Xitija closed this Aug 5, 2022
@Xitija Xitija reopened this Aug 5, 2022
@Xitija Xitija changed the base branch from release-4.10.2 to release-4.10.3 August 5, 2022 04:38
Copy link
Contributor

@rajeevsathish rajeevsathish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please push the yarn.lock file also with the package.json

@Xitija
Copy link
Contributor Author

Xitija commented Aug 5, 2022

can you please push the yarn.lock file also with the package.json

@rajeevsathish
Sir which file exactly am I supposed to add ?
I found yarn.lock files in

  • src/desktop/OpenRAP/yarn.lock
  • src/desktop/yarn.lock
  • src/app/yarn.lock
  • src/app/client/yarn.lock
  • yarn.lock (Empty file)

Also the files contain the warning :
THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY.

If I dont make a change then I cannot commit the file.
I am relatively new to this , please tell me if I am missing anything?

cc :@baljeetsingh

@rajeevsathish
Copy link
Contributor

can you please push the yarn.lock file also with the package.json

@rajeevsathish Sir which file exactly am I supposed to add ? I found yarn.lock files in

  • src/desktop/OpenRAP/yarn.lock
  • src/desktop/yarn.lock
  • src/app/yarn.lock
  • src/app/client/yarn.lock
  • yarn.lock (Empty file)

Also the files contain the warning : THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY.

If I dont make a change then I cannot commit the file. I am relatively new to this , please tell me if I am missing anything?

cc :@baljeetsingh

you are pushing package.json of client so post you update the version you need to run the yarn install in your local and push the yarn.lock of the client that will have the latest version that you have updated

@Xitija Xitija closed this Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants