Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Research if changes in builder config are necessary after deprecation of includeCore flag #376

Closed
pmalek-sumo opened this issue Dec 29, 2021 · 1 comment
Assignees

Comments

@pmalek-sumo
Copy link
Contributor

Given open-telemetry/opentelemetry-collector#4087 was merged we might need to adjust builder config in order to get rid of this warning:

2021-12-29T10:23:30.822+0100    WARN    builder/config.go:107   IncludeCore is deprecated. Starting from v0.41.0, you need to include all components explicitly.
go.opentelemetry.io/collector/cmd/builder/internal/builder.(*Config).Validate
        go.opentelemetry.io/collector/cmd/builder/internal/builder/config.go:107
go.opentelemetry.io/collector/cmd/builder/internal.Command.func1
        go.opentelemetry.io/collector/cmd/builder/internal/command.go:42
github.com/spf13/cobra.(*Command).execute
        github.com/spf13/[email protected]/command.go:856
github.com/spf13/cobra.(*Command).ExecuteC
        github.com/spf13/[email protected]/command.go:974
github.com/spf13/cobra.(*Command).Execute
        github.com/spf13/[email protected]/command.go:902
main.main
        go.opentelemetry.io/collector/cmd/builder/main.go:26
runtime.main
        runtime/proc.go:255
@pmalek-sumo pmalek-sumo self-assigned this Dec 29, 2021
@pmalek-sumo
Copy link
Contributor Author

Some of the changes needed to be done as part of https://github.com/SumoLogic/sumologic-otel-collector/pull/397/files#diff-b0288799869e6fd90e7f631f936f5a647bde1fd5fbe3334364ac869d4829976c in order to include code plugins.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant