-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Font styling broke in latest update #225
Comments
Looks like there were many changes last night. I followed the steps in the README, and using these values in // Documentation at https://www.sublimetext.com/docs/themes.html
{
"variables": {
"font_face": "Lucida Grande",
"font_size": 12,
},
"rules": [
]
} |
Which ST build are you using? |
|
Hm, this issue is odd because the theme uses You wouldn't happen do have some override of the theme lying around? What does |
and it reproduces on restart until I add that customization. |
Ah, I think this is moreso related to the font_size setting rather than font_face, since the Default theme uses 12 pt for that while Spacegray now uses 1.2rem, which seems about accurate in relation to your editor font size (after eyeballing it). |
When I went to the linked URL, I noticed that the documentation says |
Just adding (clarifying) that the 2.0.0 update produced an unexpected (and unwanted) change in the font size of the user interface. With the global font size now set to 1.2rem in the theme file, the font size of eg. tab labels appears to be 1.2x whatever I have set for the editor font size in my user preferences. I think this is the opposite of the general design principles applied to ST – or at least the core themes, where user interface labels are generally smaller than the editor font size. See comparison screenshot. I've added |
|
Relative font size support had been added to ST to exactly enable "auto-adjusting" UI font sizes according to user preferences. It however seems ST treats theme font sizes and editor font sizes different on each platform. Latest theme changes were developed on Windows on which UI fonts always appear too small compared to the editor when setting both to same size (e.g. 12pt). Here is how it looks on Windows.
This seems not the case on MacOS at least. |
Today, my font size and padding unexpectedly:
I also notice that an update was pushed yesterday. I suspect the upgrade may have broken the styling.
The text was updated successfully, but these errors were encountered: