Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font styling broke in latest update #225

Closed
appsforartists opened this issue Sep 4, 2024 · 10 comments
Closed

Font styling broke in latest update #225

appsforartists opened this issue Sep 4, 2024 · 10 comments

Comments

@appsforartists
Copy link

Today, my font size and padding unexpectedly:

Screenshot 2024-09-04 at 5 59 44 PM

I also notice that an update was pushed yesterday. I suspect the upgrade may have broken the styling.

@appsforartists
Copy link
Author

appsforartists commented Sep 4, 2024

Looks like there were many changes last night. I followed the steps in the README, and using these values in UI: Customize Theme fixes it:

// Documentation at https://www.sublimetext.com/docs/themes.html
{
  "variables": {
    "font_face": "Lucida Grande",
    "font_size": 12,
  },
  "rules": [
  ]
}

@FichteFoll
Copy link
Member

Which ST build are you using?

@appsforartists
Copy link
Author

Which ST build are you using?

4180

@FichteFoll
Copy link
Member

Hm, this issue is odd because the theme uses "system" by default, which is the same as the Default and Adaptive themes use.

You wouldn't happen do have some override of the theme lying around? What does sublime.find_resources("Spacegray.sublime-theme"); sublime.find_resources("Spacegray Oceanic.sublime-theme"); in the console yield? Doesthe issue go away after an ST restart, i.e. without your font_face variable modification?

@appsforartists
Copy link
Author

appsforartists commented Sep 4, 2024

>>> sublime.find_resources("Spacegray.sublime-theme"); sublime.find_resources("Spacegray Oceanic.sublime-theme");
['Packages/Theme - Spacegray/Spacegray.sublime-theme']
['Packages/Theme - Spacegray/Spacegray Oceanic.sublime-theme', 'Packages/User/Spacegray Oceanic.sublime-theme']

and it reproduces on restart until I add that customization.

@FichteFoll
Copy link
Member

Ah, I think this is moreso related to the font_size setting rather than font_face, since the Default theme uses 12 pt for that while Spacegray now uses 1.2rem, which seems about accurate in relation to your editor font size (after eyeballing it).

@appsforartists
Copy link
Author

When I went to the linked URL, I noticed that the documentation says font.face and this is using font_face. Is that deviation intentional? I can foresee it being a source of confusion.

@erlandh
Copy link

erlandh commented Sep 4, 2024

Just adding (clarifying) that the 2.0.0 update produced an unexpected (and unwanted) change in the font size of the user interface. With the global font size now set to 1.2rem in the theme file, the font size of eg. tab labels appears to be 1.2x whatever I have set for the editor font size in my user preferences. I think this is the opposite of the general design principles applied to ST – or at least the core themes, where user interface labels are generally smaller than the editor font size. See comparison screenshot. I've added "font_size": "0.85rem", to my theme customisation file now, but just putting this here to question whether it should be the default.

spacegray-2-font-size

@deathaxe
Copy link
Member

deathaxe commented Sep 7, 2024

I noticed that the documentation says font.face and this is using font_face.

font.face is the theme rule attribute.

font_face is a variable defined by Spacegray theme in variables section, to enable global font customization of all UI elemets.

@deathaxe
Copy link
Member

deathaxe commented Sep 7, 2024

With the global font size now set to 1.2rem in the theme file, the font size of eg. tab labels appears to be 1.2x whatever

Relative font size support had been added to ST to exactly enable "auto-adjusting" UI font sizes according to user preferences.

It however seems ST treats theme font sizes and editor font sizes different on each platform.

Latest theme changes were developed on Windows on which UI fonts always appear too small compared to the editor when setting both to same size (e.g. 12pt).

Here is how it looks on Windows.

  • theme font size: 12pt
  • editor font size: 10pt

grafik

This seems not the case on MacOS at least.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants