Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme request: Monokai - Spacegray Eighties #425

Closed
1 task done
torrentails opened this issue Sep 29, 2016 · 4 comments
Closed
1 task done

Theme request: Monokai - Spacegray Eighties #425

torrentails opened this issue Sep 29, 2016 · 4 comments
Labels
feature 😍 help wanted 🙏 Extra attention is needed

Comments

@torrentails
Copy link
Collaborator

Unstyled Content

  • No other existing issue and/or pull request.

Feature Request

Monokai - Spacegray Eighties theme from Sublime Text.
The Monokai theme already available is nice, but the background colour is ugly and some of the syntax highlighting isn't quite the same colour and it's bugging me.

https://github.com/pyoio/monokai-spacegray

@Mottie
Copy link
Member

Mottie commented Sep 29, 2016

Hi @torrentails!

We would love to be able to easily add new themes, but GitHub is using "prettylights" as their syntax highlighter, which hasn't been publicly released. It is pretty much impossible to find themes for it.

The themes we have were all hand-crafted to the best of our ability. They aren't perfect, because prettylights wraps code it find relevant a lot differently from other syntax highlighters.

It would help us greatly if you would assist in creating this theme. There are actually three different syntax highlighters on GitHub:

  1. GitHub (prettylights)

    This GitHub style would need to be hand crafted.

    We do have a _template.css file which can be modified. It contains relatively accurate comments for each entry (it's changed several times).

    Or, use the github-syntax-theme-generator created by GitHub. It is set up by defining a JSON file with color definitions; but I have yet to get it to work for me.

  2. CodeMirror (editor)

    A CodeMirror style might be converted from the tmtheme using either of these converters (I have yet to attempt it): https://github.com/codio/tmthemeConverter or https://github.com/dignifiedquire/tmthemeConverter

  3. Pygments (used by Jupyter pages).

    Converting the tmTheme you share into a pygments style wouldn't be difficult, using the pygments-from-tmtheme script for python listed on this page.

As a last resort, each of these styles have a _template.css in their respective directories which can be modified if the above methods don't work.

@Mottie Mottie added feature 😍 help wanted 🙏 Extra attention is needed labels Sep 29, 2016
@Mottie Mottie mentioned this issue Sep 29, 2016
3 tasks
@torrentails
Copy link
Collaborator Author

I'll have a look at getting this done myself a bit latter today then.

@Mottie
Copy link
Member

Mottie commented Oct 1, 2016

Thanks again for all your help!

@Mottie Mottie closed this as completed Oct 1, 2016
@torrentails
Copy link
Collaborator Author

No worries, glad I could help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature 😍 help wanted 🙏 Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants